Brave Browser Bug Fix

In this lab, our task was to fix a bug in the Brave Browser.  The bug was when a URL containing white-spaces in specific places were passed through the URL Bar the result would be much different than what the other browsers would produce.

The first step in fixing the bug was to re-create the bug.  This was very simple as we just passed through a URL which contained spaced and behold the bug appeared. I also tried inputting the same URL's in other browsers such as Chrome and Firefox and this issue did not occur. So the tests that worked and the ones that didn't work in Brave are as follows.

"dog" --> worked
" dog " --> worked
"dog cat" --> worked
" dog cat " --> worked
"https://www.google.ca/search?q=dog" --> worked
" https://www.google.ca/search?q=dog " --> worked
"https://www.google.ca/search?q=dog cat" -> Didn't work, it searches the link instead
" https://www.google.ca/search?q=dog cat " -> Didn't work, it searches the link instead

"/home/pranoy/Desktop/dog cat.txt" --> Didn't work, searches for the whole string
" /home/pranoy/Desktop/dog cat.txt " --> Didn't work, searches for the whole string
"file:///home/pranoy/Desktop/dog cat.txt" --> worked
" file:///home/pranoy/Desktop/dog cat.txt " --> worked

The fix for this was fairly simple.  It was just changing one line of code


This line just replaces an empty white-space with "%20".  This seemed like the only issue to fix and after this I ran Brave in debug mode and tested out the results with the strings mentioned above that didn't work. This proved to be a success. Below are the screenshots that show that the code fix was successful.


After this we added some test cases for the cases that weren't working before and now they are.  The test also pass.

Comments

Post a Comment

Popular posts from this blog

Assignment 1 - DPS909

   For this assignment, our task was to use Google's libphonenumber library and create a RESTful api web service which would get the phone numbers from a string that is provided and also from a file that is provided.  The initial task was to determine what language we want to use to achieve the final result.  For me, I went with JavaScript, as I have worked with JavaScript before and would require less effort to achieve the result.  So for this assignment I used Node.js which is a JavaScript run-time environment which allows the execution of JavaScript code on the server-side. Dependencies used with Node.js express google-libphonenumber multer body-parser mocha chai chai-http nodemon     Express is a framework that allows the creation of web applications for Node.js.  This specific framework is the most standard framework for Node.js, which helped in making the decision rather simple.  I also used the google-libphonenumber package which uses the original libphone
Read more

ECMA Script Testing

Image
For this lab we looked at the ECMAscript test suite. Setting it up and making it run was fairly simple and I didn't encounter any issues.  I just followed the steps provided in https://github.com/bterlson/test262-harness#test262-harness While running the tests not all of them pass. I thought this might have been a Windows issue. Therefore I tried it on my Linux machine and majority of it worked except 6. Then we looked at the test cases for Array.prototype.reverse().  For the task of this lab I simply just rewrote some new test cases to check the array.reverse.  This was fairly simple as looking at the other test cases it gave a general idea on how to write test cases for this. The test case I wrote can be found here. https://gist.github.com/pranoy10/10fd4bbf04a7490567d527017c8d52df
Read more

Release 0.2 - Bug fix

   The bug I decided to fix for this release was a very quick and easy one.  It was to update the show more button.  It can be found here . It is not really a bug but it was a minor change that they wanted. Using devtools in the VSCode, it was very easy to figure out which file was the one that needed the change. It was in the  src/components/SecondaryPanes/CommandBar.css . The Line was changed to: mask : url ( / mc/command-chevron .svg ) no-repeat ; Since this was a fairly simple bug to fix, I went ahead and decided to learn more about how the project structure is. This would help me tremendously since I plan on working on the same project for the next release.
Read more